Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _asarray #1025

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove _asarray #1025

merged 1 commit into from
Oct 10, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 10, 2024

Given the helper was based on an ancient issue, I think it is no longer needed.


📚 Documentation preview 📚: https://pytensor--1025.org.readthedocs.build/en/1025/

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (be358ed) to head (2e61d5d).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/sparse/basic.py 90.90% 1 Missing ⚠️
pytensor/sparse/rewriting.py 50.00% 1 Missing ⚠️
pytensor/tensor/type.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   81.80%   81.81%           
=======================================
  Files         183      182    -1     
  Lines       47802    47778   -24     
  Branches     8599     8597    -2     
=======================================
- Hits        39106    39088   -18     
+ Misses       6527     6523    -4     
+ Partials     2169     2167    -2     
Files with missing lines Coverage Δ
pytensor/scalar/basic.py 80.42% <100.00%> (+<0.01%) ⬆️
pytensor/tensor/basic.py 91.53% <100.00%> (-0.01%) ⬇️
pytensor/tensor/elemwise.py 88.96% <100.00%> (-0.02%) ⬇️
pytensor/tensor/extra_ops.py 88.01% <100.00%> (+0.27%) ⬆️
pytensor/tensor/math.py 91.12% <100.00%> (-0.01%) ⬇️
pytensor/tensor/random/op.py 93.71% <100.00%> (-0.04%) ⬇️
pytensor/tensor/rewriting/math.py 89.87% <100.00%> (-0.01%) ⬇️
pytensor/tensor/shape.py 90.74% <100.00%> (-0.02%) ⬇️
pytensor/tensor/sharedvar.py 91.30% <100.00%> (-0.19%) ⬇️
pytensor/tensor/sort.py 100.00% <100.00%> (ø)
... and 4 more

@ricardoV94 ricardoV94 requested a review from lucianopaz October 10, 2024 10:35
Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit f022e51 into pymc-devs:main Oct 10, 2024
60 of 61 checks passed
@ricardoV94 ricardoV94 deleted the remove_asarary branch October 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants